Skip to content

feat: migrate AppDelegate to Swift and remove legacy files for improved architecture #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: new-arch/master
Choose a base branch
from
Draft

feat: migrate AppDelegate to Swift and remove legacy files for improved architecture #660

wants to merge 10 commits into from

Conversation

lposen
Copy link
Contributor

@lposen lposen commented Jun 11, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

lposen added 9 commits June 10, 2025 12:26
@lposen
feat: add support for new architecture and update dependencies in pac…
a14d8ca 
…kage.json
@lposen
feat: expand NativeIterableModuleSpec with additional SDK functions
370edaf
@lposen
refactor: rename NativeIterableModuleSpec to NativeRNIterableApi and …
bdce48e 
…update types for SDK functions
@lposen
refactor: update RNIterableAPI imports for new arch
e9b3788
@lposen
feat: introduce RNEventEmitter for event handling and update API imports
dbce20c
@lposen
feat: add RNIterableAPI module with support for new architecture and …
f24aa4f 
…update podspec
@lposen
refactor: update Podfile and package.json to use latest version of cl…
0b955cf 
…i-platform-ios
@lposen
feat: add script to generate native code and update IterableAuthRespo…
32374cb 
…nse types for better null handling
@lposen
feat: migrate AppDelegate to Swift and remove legacy files for improv…
520ebb3 
…ed architecture
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 11, 2025 •
edited
Loading

❌ 5 blocking issues (5 total)

Tool Category Rule Count
eslint Lint Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
3 ❌
eslint Lint Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. 2 ❌

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

codeclimate[bot]
codeclimate bot reviewed Jun 11, 2025
View reviewed changes
src/core/api/NativeRNIterableApi.ts
@@ -0,0 +1,113 @@
import { type TurboModule, TurboModuleRegistry } from 'react-native';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/core/api/RNEventEmitter.ts
@@ -0,0 +1,4 @@
import { NativeEventEmitter, NativeModules } from 'react-native';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/core/api/index.ts
@@ -0,0 +1,9 @@
import TurboIterableModule from './NativeRNIterableApi'; // new arch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/core/classes/Iterable.ts
@@ -714,6 +721,7 @@ export class Iterable {
) {
Iterable?.logger?.log('updateUser');

// @ts-ignore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

src/core/classes/IterableConfig.ts
dataRegion: this.dataRegion,
// @ts-ignore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

codeclimate[bot]
codeclimate bot reviewed Jun 11, 2025
View reviewed changes
src/core/api/NativeRNIterableApi.ts
@@ -0,0 +1,113 @@
import { type TurboModule, TurboModuleRegistry } from 'react-native';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/core/api/RNEventEmitter.ts
@@ -0,0 +1,4 @@
import { NativeEventEmitter, NativeModules } from 'react-native';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/core/api/index.ts
@@ -0,0 +1,9 @@
import TurboIterableModule from './NativeRNIterableApi'; // new arch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/core/classes/Iterable.ts
@@ -714,6 +721,7 @@ export class Iterable {
) {
Iterable?.logger?.log('updateUser');

// @ts-ignore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

src/core/classes/IterableConfig.ts
dataRegion: this.dataRegion,
// @ts-ignore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "@ts-expect-error" instead of "@ts-ignore", as "@ts-ignore" will do nothing if the following line is error-free. [eslint:@typescript-eslint/ban-ts-comment]

Suggested change
// @ts-ignore
// @ts-expect-error

Replace "@ts-ignore" with "@ts-expect-error".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lposen